refaktor címtár

backend/app/api/v1/endpoints/expenses.py

@@ -10,6 +10,7 @@ from app.api.deps import get_db, get_current_user, RequireOrgCapability
 from app.models import Asset, AssetCost, AssetEvent, OrganizationMember, SystemParameter, OrgRole, CostCategory, Organization
 from app.schemas.asset_cost import AssetCostCreate, AssetCostUpdate
 from app.services.provider_service import find_or_create_provider_by_name
+from app.services.gamification_service import gamification_service
 from datetime import datetime, timezone
 
 logger = logging.getLogger(__name__)
@@ -567,20 +568,42 @@ async def create_expense(
     # ── PROVIDER AUTO-DISCOVERY HOOK (Card #360) ──
     # Ha external_vendor_name meg van adva, de service_provider_id nincs,
     # automatikusan felfedezzük vagy létrehozzuk a providert.
-    # A find_or_create_provider_by_name() kezeli a gamification pontok kiosztását is
-    # (PROVIDER_DISCOVERY / PROVIDER_CONFIRMATION / PROVIDER_VERIFIED_USE).
+    #
+    # P0 ARCHITECTURE CLEANUP (2026-07-01):
+    # A gamification/XP logika ELTÁVOLÍTVA a service rétegből.
+    # A find_or_create_provider_by_name() már csak (provider, created) tuple-t ad vissza.
+    # Ha created=True (új provider felfedezve), itt az API rétegben hívjuk meg
+    # a gamification_service.award_points()-t a PROVIDER_DISCOVERY action_key-kel.
     resolved_provider_id = expense.service_provider_id
     if expense.external_vendor_name and not expense.service_provider_id:
         try:
-            provider, action_key = await find_or_create_provider_by_name(
+            provider, created = await find_or_create_provider_by_name(
                 db=db,
                 name=expense.external_vendor_name,
                 added_by_user_id=current_user.id,
             )
             resolved_provider_id = provider.id
+
+            # P0 ARCHITECTURE CLEANUP: Gamification XP kiosztása az API rétegben
+            # Csak akkor adunk XP-t, ha a provider újonnan lett felfedezve (created=True)
+            if created:
+                await gamification_service.award_points(
+                    db=db,
+                    user_id=current_user.id,
+                    amount=0,
+                    reason="PROVIDER_DISCOVERY",
+                    commit=False,  # A hívó (create_expense) kezeli a commit-ot
+                    action_key="PROVIDER_DISCOVERY",
+                )
+                logger.info(
+                    f"Gamification XP awarded for PROVIDER_DISCOVERY: "
+                    f"name='{expense.external_vendor_name}', "
+                    f"provider_id={provider.id}, user_id={current_user.id}"
+                )
+
             logger.info(
                 f"Provider auto-discovery: name='{expense.external_vendor_name}', "
-                f"provider_id={provider.id}, action_key='{action_key}', "
+                f"provider_id={provider.id}, created={created}, "
                 f"user_id={current_user.id}"
             )
         except Exception as e: